Issue with Button in AlertDialog (Floating off screen)

Question

Here's an image of what my issue looks like:

That box at the bottom is the top half of a button. Whenever I've got too many Stock Options in the dialog box, it first forces the button off screen, THEN it scrolls. I want the button fixed at the bottom of the dialog and then have the scrolling happen.

Here's the code:

public void buyStock(View view){
    Context context = getApplicationContext();

    //create ScrollView to hold everything
    ScrollView scrollView = new ScrollView(context);

    //generate content for dialog       
    LinearLayout dialogContainer = new LinearLayout(context);
    dialogContainer.setOrientation(LinearLayout.VERTICAL);
    LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(LinearLayout.LayoutParams.WRAP_CONTENT, 400, 1);
    dialogContainer.setLayoutParams(params);
    dialogContainer.setPadding(15, 15, 0, 15);
    dialogContainer.setBackgroundColor(Color.WHITE);

    //each hotel stock options
    for (int i = 0; i < hotels.size(); i++) {
        Hotel testHotel = hotels.get(i);
        testHotel.setPrice(200);
        View stockPicker = getStockPicker(testHotel);
        LinearLayout.LayoutParams pickerParams = new LinearLayout.LayoutParams(LinearLayout.LayoutParams.WRAP_CONTENT, 100, 1.0f);
        pickerParams.gravity = Gravity.LEFT;
        stockPicker.setLayoutParams(pickerParams);
        dialogContainer.addView(stockPicker);
        stockPicker.setBackgroundColor(0xffffff);
    }

    scrollView.addView(dialogContainer);

    LinearLayout dialogLayout = new LinearLayout(context);
    dialogLayout.setOrientation(LinearLayout.VERTICAL);

    Button buyButton = new Button(context);
    LinearLayout.LayoutParams buttonParams = new LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT, 100);
    buyButton.setLayoutParams(buttonParams);

    LinearLayout buttonLayout = new LinearLayout(context);
    buttonLayout.addView(buyButton);

    dialogLayout.addView(scrollView);
    dialogLayout.addView(buttonLayout);

    ContextThemeWrapper ctw = new ContextThemeWrapper(this, R.style.AppTheme);

    AlertDialog.Builder buyStockDialog = new AlertDialog.Builder(ctw);
    buyStockDialog.setTitle("Buy Stock: ");
    buyStockDialog.setView(dialogLayout);

    buyStockDialog.show();

}

Answer 1

Make dialogLayout a RelativeLayout, and then declare buttonParams as a RelativeLayout.LayoutParams (layout params are declared according the parent viewgroup type, which for buyButton is now a RelativeLayout). Your also going to need to declare a RelativeLayout.LayoutParams for scrollView.

note: This code is in c#/monodroid, not raw java/android, so some quick porting of some of the methods and constants may need to be required, but shouldn't be too time consuming.

If this doesn't work out exactly trying experimenting with other combinations of the RelativeLayout position rules and/or gravity. Let me know if it doesn't work out.

RelativeLayout.LayoutParams scrollParams = new RelativeLayout.LayoutParams(LayoutParams.WRAP_CONTENT, some_height);

RelativeLayout.LayoutParams buttonParams = new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, 100);

Then, add these statements to control where scrollView and buyButton are positioned

scrollParams.AddRule(LayoutRules.AlignParentLeft);
scrollParams.AddRule(LayoutRules.AlignParentTop);

buttonParams.AddRule(LayoutRules.Below, scrollView.Id);

The for the getting the button on the bottom of the screen, try one of two things

buttonParams.AddRule(LayoutRules.AlignParentBottom);

or

buyButton.Gravity = Gravity.BOTTOM

Answer 2

Try explicitly setting a fixed height to the scrollView

scrollView.LayoutParameters.Height = HEIGHT;

I think it defaults to WRAP_CONTENT if not specified, and is why its scaling.

You may have to set it in a layout file if you cant from code

<ScrollView
  android:id="@+id/scroll_view_1
  android:layout_width="wrap_content"
  android:layout_height="100"/>

and then change

ScrollView scrollView = new ScrollView(context);

to

ScrollView scrollView = findViewById(R.Id.scroll_view_1, this);

Answer 3

Try wrapping the scrollView in another LinearLayout, and set this new layout's height to a fixed width that keeps the button low enough to your liking. You can actually replace the Scrollview with a ListView, but don't do this until after at least trying to get this fix working first. ListViews scroll, but you'd still face this problem without this fix.

---

To fix the new issue you mentioned below (with some quick and dirty code, you should use trial and error to fix it correctly), try the following

//each hotel stock options
for (int i = 0; i < hotels.size(); i++) 
{
   // ...
}

if( hotels.size() < numberOfItemsNeededForCorrectView )
{
   for( int i=0; i < numberOfItemsNeededForCorrectView - hotels.size(); i++ )
   {
        View blankView = new View(context);
        LinearLayout.LayoutParams viewParams = new LinearLayout.LayoutParams(1, 100);

        blankView.setLayoutParams(viewParams);
        blankView.setViewState(ViewState.INVISIBLE);
        dialogContainer.addView(stockPicker);
   }
}

You can try replacing your scrollView with a list view still and see if that fixes things. You can also try tweaking layout and gravity settings until you get it, or trying introducing other layouts or reorganizing your layouts (or using RelativeLayout, its really not that bad).

Answer 4

So, now in 2022 I've also had this problem. I've just set fixed size for ScrollView in fragment layout xml-file. When you have this problem, you can set, for example, 150dp or 200dp and be happy! And for more convenience, you can create special layout for landscape screen orientation and set fixed layout_height size there. I'm really confused that there's no information about this problem besides this page on the Internet.

<ScrollView
    android:layout_width="match_parent"
    android:layout_height="200dp">
    <!--your view into scrollView here-->
</ScrollView>