'Pygame- Pong- rectangle doesnt move while pressing w or s

Pygame -Pong- rectangle doesn't move while pressing w or s

I just don't get why its not moving plz help i am new at python :3

import pygame
import sys
import numpy as np


class Game( ):
    def __init__(self):
        pygame.init( )

        self.player_x = 75
        self.player_y = 300
        self.player1_x = 1100
        self.player1_y = 300
        self.screen = pygame.display.set_mode((1200, 800))
        pygame.display.set_caption("Pong")
        self.FPS = pygame.time.Clock( )
        self.player_speed = 0

        self.width = 25
        self.hight = 100
        self.speed = 5


        self.game_loop()

    def game_loop(self):
        while True:
            self.FPS = pygame.time.Clock()

            for event in pygame.event.get( ):
                if event.type == pygame.QUIT:
                    pygame.quit()
                    sys.exit()
                if event.type == pygame.KEYDOWN:
                    if event.key == pygame.K_w:
                        self.player_speed -= 7
                    if event.key == pygame.K_s:
                        self.player_speed += 7

            self.screen.fill((0, 0, 0))
            self.Player_1()

            self.player.y += self.player_speed
            self.player1.y += self.player_speed



            pygame.display.flip()
            self.FPS.tick(60)




    def Player_1(self):

        self.player = pygame.Rect(self.player_x, self.player_y, self.width, self.hight)
        self.player1 = pygame.Rect(self.player1_x, self.player1_y, self.width, self.hight)
        pygame.draw.rect(self.screen, "Red", self.player)
        pygame.draw.rect(self.screen, "Red", self.player1)


Game( )


Solution 1:[1]

You're defining the players props as:

self.player_x = 75
self.player_y = 300
self.player1_x = 1100
self.player1_y = 300

But you're setting:

self.player.y += self.player_speed
self.player1.y += self.player_speed

Which trows an:

AttributeError: 'Game' object has no attribute 'player'


So change the above to:

self.player_y += self.player_speed
self.player1_y += self.player_speed

And the rectangles will move on w and s.

Sources

This article follows the attribution requirements of Stack Overflow and is licensed under CC BY-SA 3.0.

Source: Stack Overflow

Solution Source
Solution 1 0stone0