Demonstrating the contents of an array but it populates wrong numbers

Question

I'm new to C#, and I am supposed to be demonstrating creating arrays and processing the contents of the arrays. Whenever I press calculate I get the same numbers every time. I am not sure what I am missing? I changed double to decimals thinking that might help change things, but no matter what I try to fix it still comes up the same. Any help in this is appreciated. I also had to save a .txt file into the same folder as the bin/debug for this project. Im instructed that this is supposed to read the files content into the array of double or decimal. the folder just has a few numbers with decimals (1260.07, etc)

heres the code I have so far.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.IO;

namespace WindowsFormsAppAssignment6
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        private void analyzeBtn_Click(object sender,System.EventArgs e)
        {       
            string file = "Sales.txt";
            string salesValue;
            Decimal[] sales = new decimal[7];
            int count = 0;
            decimal maxSales = Decimal.MinValue;
            decimal minSales = Decimal.MaxValue;
            decimal totalSales = 0;
            try
            { 
                StreamReader dataStream = new StreamReader(file);

                salesValue = dataStream.ReadLine();

                var total = sales.Sum();

                var average = sales.Average();

                var high = sales.Max();

                var low = sales.Min();

                while (salesValue != null)
                {
                    sales[count] = Convert.ToDecimal(salesValue);
                    totalSales += sales[count];

                    if (sales[count] > maxSales)
                        maxSales = sales[count];

                    if (sales[count] < minSales)
                        minSales = sales[count];


                    count++;

                    salesValue = dataStream.ReadLine();
                }

                dataStream.Close();
            
                for (int item = 0; item < 7; item++)
                    salesListBox.Items.Add(sales[item]);

          
                totalLbl.Text = totalSales + "";
                avgLabel.Text = totalSales  + "";
                highSalesLabel.Text = maxSales + "";
                smallSalesLabel.Text = minSales + "";
   

         
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message);
            }
        }
        private void label3_Click(object sender, EventArgs e)
        {

        }

        private void exitBtn_Click(object sender, EventArgs e)
        {
            this.Close();
        }
    }
}'''

Heres what populates every time.

Answer 1

The problem I think is with your error handling or the format of your document. Convert will actually throw an exception which will kill your entire loop if it cannot parse the current line. Say you had a simple line break in your file that created an empty line, you would try to parse it, an error is thrown, your code does nothing after it. Since I didnt have your file and I really do not feel like using visual studio instead of vscode, I replaced your streamreader with a stringreader (reads a string instead of a file but almost exactly the same) and i replaced the form with simple console writes. Outside of those changes, I gave myself some extra room in the array size since it was throwing exceptions and i wrapped the inside of the while loop in a try catch for format exceptions which is what Convert throws. After I made those changes, the outputs all worked properly. If you still dont see the values, then it is a problem with how you are using windows forms not your codes logic itself.

public static void Main()
{
    Console.WriteLine("Hello World");
    analyzeBtn_Click();
}


public static string SalesTxt = @"
1260.07
4002.52
267.21
15773.223
66655.2
555.0
7322
";





 private static void analyzeBtn_Click()
    {       
        string salesValue;
        Decimal[] sales = new decimal[8];
        int count = 0;
        decimal maxSales = Decimal.MinValue;
        decimal minSales = Decimal.MaxValue;
        decimal totalSales = 0;
        try
        { 
            StringReader  dataStream = new StringReader(SalesTxt);

            salesValue = dataStream.ReadLine();

            var total = sales.Sum();
            var average = sales.Average();
            var high = sales.Max();
            var low = sales.Min();

            while (salesValue != null)
            {
                try {
                    sales[count] = Convert.ToDecimal(salesValue);
                    
                    totalSales += sales[count];

                    if (sales[count] > maxSales)
                        maxSales = sales[count];

                    if (sales[count] < minSales)
                        minSales = sales[count];


                    count++;
                } catch (FormatException) {Console.WriteLine("\tException: '"+ salesValue + "'"); }

                salesValue = dataStream.ReadLine();
            }

            dataStream.Close();
        
            string listItems = string.Join(",\n", sales);
            
      
            Console.WriteLine(listItems);
            Console.WriteLine(totalSales);
            Console.WriteLine(maxSales);
            Console.WriteLine(minSales);
     
        } catch (Exception ex) {
            Console.WriteLine(ex);
        }
    }

Output:

Hello World
    Exception: ''
    Exception: '    '
1260.07,
4002.52,
267.21,
15773.223,
66655.2,
555.0,
7322,
0
95835.223
66655.2
267.21

EDIT:

In light of discussion, I have moved the string into a file with the appropriate name and used StreamReader just as you originally did. Using the same code as above just slightly modified, I was still able to get the correct output.