'.innerHTML problems storing it into a variable

Here is my code that is not working - thanks guys - first question!

<html>
<head>
<script type="text/javascript">
var x =document.getElementById("myElementId").innerHTML;


</script>

</head>

<body>
<div id="myElementId">24</div>
<div>

<script type="text/javascript">
if (x < 25) {
document.write("worked")
}
else {
document.write("didn't work")
}
</script>

Also sorry for the update but do you guys have an idea of how to do this when the div is in an iframe thats not on the same domain? Thanks

javascript innerhtml

Solution 1:^[1]

This line

var x = document.getElementById("myElementId").innerHTML;

is executed before the element with ID myElementId exists, so JavaScript cannot find it (getElementById returns null).

Put it after the element:

<div id="myElementId">24</div>
<script>
    var x = document.getElementById("myElementId").innerHTML;
</script>

The HTML document is processed from top to bottom.

Solution 2:^[2]

You're running this line:

var x =document.getElementById("myElementId").innerHTML;

before the element exists. Remove the script from the head an put that line right before:

if(x < 25) {

Instead.

Solution 3:^[3]

In addition to the creating the element first,

I believe innerHtml returns a string value Try parsing it first;

var value  = document.getElementById("myElementId").innerHTML;
var x   = parseInt(value,10)

Solution 4:^[4]

change it to:

<html>
<head>


</head>

<body>
<div id="myElementId">24</div>
<div>

<script type="text/javascript">
var x =document.getElementById("myElementId").innerHTML;
if (x < 25) {
document.write("worked")
}
else {
document.write("didn't work")
}
</script>

the element that you are trying to look for does not even exist on the page when you run the script that is why you have run into this issue..

Solution 5:^[5]

document.getElementById("myElementId").innerHTML;

You have to use a # with Id and . with class in it

document.getElementById("#myElementId").innerHTML;

Sources

This article follows the attribution requirements of Stack Overflow and is licensed under CC BY-SA 3.0.

Source: Stack Overflow

Solution	Source
Solution 1	Felix Kling
Solution 2	Paul
Solution 3	Richard A
Solution 4
Solution 5	Overflow150

'.innerHTML problems storing it into a variable

Solution 1:[1]

Solution 2:[2]

Solution 3:[3]

Solution 4:[4]

Solution 5:[5]