Doctrine 2 - On duplicate key update

Question

I have a User Entity which is associated with a Role Entity using a many to many join table.

My issue is when I come to update it.

It throws the following error:

An exception occurred while executing 'INSERT INTO user_role (user_id, role_id) VALUES (?, ?)' with params [38, 3]:

SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '38-3' for key 'PRIMARY'

Now if I am understanding this correctly the issue is that I am trying to insert another row with a primary key that already exists.

Join table schema that doctrine generated below.

+---------+---------+------+-----+---------+-------+
| Field   | Type    | Null | Key | Default | Extra |
+---------+---------+------+-----+---------+-------+
| user_id | int(11) | NO   | PRI | NULL    |       |
| role_id | int(11) | NO   | PRI | NULL    |       |
+---------+---------+------+-----+---------+-------+

My User entity has a method setRoles() which will add the role to the ArrayCollection and then doctrine will try to execute the insert.

So I guess I'm trying to ask is there a on duplicate key method in doctrine?

Or could some one kindly give me some direction on how to achieve this even if it means regenerating a schema.

I am new to doctrine, I have followed the beginner tutorial and still mulling over the documentation.

EDIT

<?php
namespace Brs\UserBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Security\Core\User\UserInterface;
use Doctrine\Common\Collections\ArrayCollection;

class User implements UserInterface, \Serializable
{
    private $id;
    private $username;
    private $fname;
    private $lname;
    private $email;
    private $mobile;
    private $active;
    private $mentor;
    private $initialized;
    private $roles;
    private $password;
    private $tempPassword;

    public function __construct(){
        $this->roles = new ArrayCollection();
    }

    public function getTempPassword(){
        return $this->tempPassword;
    }

    public function setTempPassword($tempPassword){
        $this->tempPassword = $tempPassword;

        return $this;
    }

    public function getUsername(){
        return $this->username;
    }

    public function getSalt(){
        return null;
    }

    public function getPassword(){
        return $this->password;
    }

    public function getRoles(){
        return $this->roles->toArray();
    }

    public function getRole(){
        return $this->roles;
    }

    public function setRoles($roles){
        $this->roles[] = $roles;
        return $this;
    }

    public function eraseCredentials(){

    }

    public function serialize(){
        return serialize(array(
            $this->id,
            $this->username,
            $this->password,
        ));
    }

    public function unserialize($serialized){
        list(
                $this->id,
                $this->username,
                $this->password,
            ) = unserialize($serialized);
    }

    /**
     * Get id
     *
     * @return integer 
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Set username
     *
     * @param string $username
     * @return User
     */
    public function setUsername($username)
    {
        $this->username = $username;

        return $this;
    }

    /**
     * Set fname
     *
     * @param string $fname
     * @return User
     */
    public function setFname($fname)
    {
        $this->fname = $fname;

        return $this;
    }

    /**
     * Get fname
     *
     * @return string 
     */
    public function getFname()
    {
        return $this->fname;
    }

    /**
     * Set lname
     *
     * @param string $lname
     * @return User
     */
    public function setLname($lname)
    {
        $this->lname = $lname;

        return $this;
    }

    /**
     * Get lname
     *
     * @return string 
     */
    public function getLname()
    {
        return $this->lname;
    }

    /**
     * Set email
     *
     * @param string $email
     * @return User
     */
    public function setEmail($email)
    {
        $this->email = $email;

        return $this;
    }

    /**
     * Get email
     *
     * @return string 
     */
    public function getEmail()
    {
        return $this->email;
    }

    /**
     * Set mobile
     *
     * @param string $mobile
     * @return User
     */
    public function setMobile($mobile)
    {
        $this->mobile = $mobile;

        return $this;
    }

    /**
     * Get mobile
     *
     * @return string 
     */
    public function getMobile()
    {
        return $this->mobile;
    }

    /**
     * Set active
     *
     * @param boolean $active
     * @return User
     */
    public function setActive($active)
    {
        $this->active = $active;

        return $this;
    }

    /**
     * Get active
     *
     * @return boolean 
     */
    public function getActive()
    {
        return $this->active;
    }

    /**
     * Set mentor
     *
     * @param boolean $mentor
     * @return User
     */
    public function setMentor($mentor)
    {
        $this->mentor = $mentor;

        return $this;
    }

    /**
     * Get mentor
     *
     * @return boolean 
     */
    public function getMentor()
    {
        return $this->mentor;
    }

    /**
     * Set initialized
     *
     * @param \DateTime $initialized
     * @return User
     */
    public function setInitialized($initialized)
    {
        $this->initialized = $initialized;

        return $this;
    }

    /**
     * Get initialized
     *
     * @return \DateTime 
     */
    public function getInitialized()
    {
        return $this->initialized;
    }

    /**
     * Set password
     *
     * @param string $password
     * @return User
     */
    public function setPassword($password)
    {
        $this->password = $password;

        return $this;
    }
    /**
     * @var \Doctrine\Common\Collections\Collection
     */
    private $targetEntity;

    /**
     * @var \Doctrine\Common\Collections\Collection
     */
    private $inversedBy;


    /**
     * Add targetEntity
     *
     * @param \Brs\UserBundle\Entity\R $targetEntity
     * @return User
     */
    public function addTargetEntity(\Brs\UserBundle\Entity\R $targetEntity)
    {
        $this->targetEntity[] = $targetEntity;

        return $this;
    }

    /**
     * Remove targetEntity
     *
     * @param \Brs\UserBundle\Entity\R $targetEntity
     */
    public function removeTargetEntity(\Brs\UserBundle\Entity\R $targetEntity)
    {
        $this->targetEntity->removeElement($targetEntity);
    }

    /**
     * Get targetEntity
     *
     * @return \Doctrine\Common\Collections\Collection 
     */
    public function getTargetEntity()
    {
        return $this->targetEntity;
    }

    /**
     * Add inversedBy
     *
     * @param \Brs\UserBundle\Entity\u $inversedBy
     * @return User
     */
    public function addInversedBy(\Brs\UserBundle\Entity\u $inversedBy)
    {
        $this->inversedBy[] = $inversedBy;

        return $this;
    }

    /**
     * Remove inversedBy
     *
     * @param \Brs\UserBundle\Entity\u $inversedBy
     */
    public function removeInversedBy(\Brs\UserBundle\Entity\u $inversedBy)
    {
        $this->inversedBy->removeElement($inversedBy);
    }

    /**
     * Get inversedBy
     *
     * @return \Doctrine\Common\Collections\Collection 
     */
    public function getInversedBy()
    {
        return $this->inversedBy;
    }

    /**
     * Add roles
     *
     * @param \Brs\UserBundle\Entity\Role $roles
     * @return User
     */
    public function addRole(\Brs\UserBundle\Entity\Role $roles)
    {
        $this->roles[] = $roles;

        return $this;
    }

    /**
     * Remove roles
     *
     * @param \Brs\UserBundle\Entity\Role $roles
     */
    public function removeRole(\Brs\UserBundle\Entity\Role $roles)
    {
        $this->roles->removeElement($roles);
    }
}

Role Entity:

<?php
namespace Brs\UserBundle\Entity;

use Symfony\Component\Security\Core\Role\RoleInterface;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping as ORM;

class Role implements RoleInterface{
    private $id;
    private $name;
    private $role;
    private $users;

    public function __construct(){
        $this->users = new ArrayCollection();
    }

    public function getRole(){
        return $this->role;
    }

    /**
     * Get id
     *
     * @return integer 
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Set name
     *
     * @param string $name
     * @return Role
     */
    public function setName($name)
    {
        $this->name = $name;

        return $this;
    }

    /**
     * Get name
     *
     * @return string 
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Set role
     *
     * @param string $role
     * @return Role
     */
    public function setRole($role)
    {
        $this->role = $role;

        return $this;
    }

    /**
     * Add users
     *
     * @param \Brs\UserBundle\Entity\User $users
     * @return Role
     */
    public function addUser(\Brs\UserBundle\Entity\User $users)
    {
        $this->users[] = $users;

        return $this;
    }

    /**
     * Remove users
     *
     * @param \Brs\UserBundle\Entity\User $users
     */
    public function removeUser(\Brs\UserBundle\Entity\User $users)
    {
        $this->users->removeElement($users);
    }

    /**
     * Get users
     *
     * @return \Doctrine\Common\Collections\Collection 
     */
    public function getUsers()
    {
        return $this->users;
    }
}

Thanks

Adam

Answer 1

@Adam There are functions on ArrayCollection for inspecting it. The first two would be contains and indexOf - these use in_array and array_search internally so I think you would need the Role you pass in to be the same instance that's in the Identity map that was loaded into the collection - because it tests against reference equality. The third, exists allows you to pass in a Closure to use as a comparison function.

I would use one of these methods inside of a hasRole method on the User entity:

public function hasRole(Role $role) {
    return $this->getRoles()->contains($role);
}

If for some reason you needed to use exists instead that could look like:

public function hasRole(Role $role) {
    return $this->getRoles()->exists(function($key, $entity) use ($role) {
         return $entity->getId() === $role->getId();
    });
}

You could of course change that method to compare more fields or something else, or allow you to pass in a set of fields for the comparison, but that doesn't seem to be needed in this instance.

Answer 2

Thanks for all your input :-).

Ok from my lack of understanding I was not aware of mysql composite keys thanks to @prodigitalson for pointing that out.

Here is what I implemented in my User Entity to check that the composite keys do not exist, If they do not then perform the insert. Thanks to @kmlnvm for the guidance on that one.

private $roleIds = array();

public function setRoles($role){
    if($role !== null){
        foreach($this->getRoles() as $currentRole){
            $this->roleIds[] = $currentRole->getId();
        }

        if(!in_array($role->getId(),$this->roleIds)){
            $this->roles[] = $role;
        }
    }

    return $this;
}

I would like input that what I have implemented, Is this a good way of doing this?

Thanks

Adam